UI Type checks for build #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nerdalert
commented
May 29, 2024
•
nerdalert
commented
- Fix type errors for prod building (npm run build)
- Add type checking to CI
- Changed custom endpoints to be processed on the client side. Most of the time that would be a user inferring on localhost or an endpoint on their private network.
- Added a cleanup button for playground chat.
- Fix type errors for prod building (npm run build) - Add type checking to CI Signed-off-by: Brent Salisbury <[email protected]>
|
@vishnoianil double check knowledge/route submission at your leisure. Had to change them to pass type checking to get prod built. Ty! |
Signed-off-by: Brent Salisbury <[email protected]>
- Custom endpoints should be processed from the client side since it will often be a localhost inference. - We also wouldn't want arbitrary proxying to models from the server side other than the predefined endpoints provided. Signed-off-by: Brent Salisbury <[email protected]>
@nerdalert tested skill/knowledge both, looks good. |
vishnoianil
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.