Skip to content

Commit

Permalink
fix misspelled parametrize
Browse files Browse the repository at this point in the history
Signed-off-by: James Kunstle <[email protected]>
  • Loading branch information
JamesKunstle committed Jan 24, 2025
1 parent 4c848b0 commit 7834684
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions tests/test_train.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
}

DEFAULT_TORCHRUN_ARGS = {
"nproc_per_node": 4, # TODO: this is runner-specific. Should parameterize from environment.
"nproc_per_node": 4, # TODO: this is runner-specific. Should parametrize from environment.
"nnodes": 1,
"node_rank": 0,
"rdzv_id": 123,
Expand Down Expand Up @@ -127,7 +127,7 @@ def test_basic_training_run(
cached_7b_model: pathlib.Path,
cached_training_data: pathlib.Path,
checkpoint_dir: pathlib.Path,
prepared_data_dir: pathlib.Path,
prepared_data_file: pathlib.Path,
) -> None:
"""
Test that runs training with as many features
Expand All @@ -137,7 +137,7 @@ def test_basic_training_run(
train_args = TrainingArgs(
model_path=str(cached_7b_model),
data_path=str(cached_training_data),
ckpt_output_dir=str(prepared_data_dir),
ckpt_output_dir=str(prepared_data_file),
**MINIMAL_TRAINING_ARGS,
)

Expand All @@ -148,10 +148,10 @@ def test_basic_training_run(

@pytest.mark.skip
@pytest.mark.slow
@pytest.mark.parameterize("cpu_offload", CPU_OFFLOADING)
@pytest.mark.parameterize("use_lora", USE_LORA)
@pytest.mark.parameterize("use_dolomite", USE_DOLOMITE)
@pytest.mark.parameterize("dist_train_framework", DIST_TRAIN_FRAMEWORKS)
@pytest.mark.parametrize("cpu_offload", CPU_OFFLOADING)
@pytest.mark.parametrize("use_lora", USE_LORA)
@pytest.mark.parametrize("use_dolomite", USE_DOLOMITE)
@pytest.mark.parametrize("dist_train_framework", DIST_TRAIN_FRAMEWORKS)
def test_training_runs(
dist_train_framework: str, use_dolomite: bool, use_lora: bool, cpu_offload: bool
) -> None: ...

0 comments on commit 7834684

Please sign in to comment.