Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update main_ds.py #210

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update main_ds.py #210

wants to merge 1 commit into from

Conversation

gxxu-ml
Copy link
Collaborator

@gxxu-ml gxxu-ml commented Sep 13, 2024

don't error out on new granite class

@gxxu-ml
Update main_ds.py
0b01e01 
support granite class

Signed-off-by: GX Xu <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 26, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. @gxxu-ml please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Sep 26, 2024
RobotSail
RobotSail approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@RobotSail RobotSail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RobotSail
Copy link
Member

Thank you for the PR @gxxu-ml !

@RobotSail
Copy link
Member

@mergeifyo rebase

@mergify mergify bot added the one-approval label Sep 26, 2024
@RobotSail
Copy link
Member

@mergify rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 26, 2024

rebase

☑️ Nothing to do

  • -conflict [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • queue-position = -1 [📌 rebase requirement]
  • any of:
    • #commits-behind > 0 [📌 rebase requirement]
    • #commits > 1 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]

@mergify mergify bot added the ci-failure label Sep 26, 2024
@JamesKunstle
Copy link
Contributor

@gxxu-ml could you please rebase and make sure linting passes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobotSail RobotSail RobotSail approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
ci-failure needs-rebase one-approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gxxu-ml @RobotSail @JamesKunstle