Docs: Update training README #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
documentation
kelbrown20
force-pushed
the
update-train-readme
branch
3 times, most recently
from
dbf5d36
to
b4789b2
Compare
kelbrown20
force-pushed
the
update-train-readme
branch
from
b4789b2
to
dbf4f05
Compare
kelbrown20
force-pushed
the
update-train-readme
branch
from
dbf4f05
to
160ac66
Compare
RobotSail
reviewed
Sep 24, 2024
RobotSail
reviewed
Sep 24, 2024
RobotSail
reviewed
Sep 24, 2024
RobotSail
reviewed
Sep 24, 2024
RobotSail
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Thank you for the awesome PR @kelbrown20 ! I have one minor comment, but otherwise LGTM
kelbrown20
force-pushed
the
update-train-readme
branch
from
160ac66
to
39e6ca2
Compare
kelbrown20
commented
Sep 25, 2024
README.md
Outdated
| Install the library for development: | ||
|
|
||
| ```bash | ||
| pip install instructlab-training -e |
There was a problem hiding this comment.
pip install -e ./training if training is cloned locally
There was a problem hiding this comment.
Ill update that now!
kelbrown20
force-pushed
the
update-train-readme
branch
from
39e6ca2
to
1c95f93
Compare
kelbrown20
force-pushed
the
update-train-readme
branch
from
1c95f93
to
faaefa8
Compare
|
This pull request has merge conflicts that must be resolved before it can be |
|
@mergify rebase |
☑️ Nothing to do
|
kelbrown20
force-pushed
the
update-train-readme
branch
from
faaefa8
to
1e5a58f
Compare
Signed-off-by: Kelly Brown <[email protected]>
kelbrown20
force-pushed
the
update-train-readme
branch
from
1e5a58f
to
d5b1ee3
Compare
|
This shouldn't have automerged and broke Markdown linting CI - fix here: #231 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR makes small updates to the training library README
You can see the preview here as well: https://github.com/kelbrown20/kelly-training/tree/update-train-readme