Fix for https://github.com/instructlab/training/issues/254 #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashna000 <[email protected]>
|
@RobotSail Can you please review this ? |
Signed-off-by: ashna000 <[email protected]>
RobotSail
reviewed
Oct 16, 2024
| @@ -76,7 +76,7 @@ def get_effective_samples_per_minibatch(num_tokens_per_gpu): | |||
| padding=True, | |||
| ) | |||
| batches = sampler.generate_batches() | |||
| return len(dataset) / len(batches) | |||
| return len(dataset) / len(batches) if len(batches) > 0 else None | |||
There was a problem hiding this comment.
If we're hitting a scenario where Multipack generated no batches, then we need to either error out and have the calling function handle it (by falling back to DistributedDataSampler, or simply by preventing us from using multipack in the first place.
My recommendation here is to do this:
- Raise an appropriate exception here (either
RuntimeErrororDivisionByZeroError) - Have the calling function check for this additional exception and fall back to the naive sampler
|
Thanks for this PR @ashna000, this will be a really important fix ! I've left a comment on how we should handle this problem. |
nathan-weinberg
requested changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added checks for resolving the issue reported in #254