Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor + add unit and smoke testing workflows. #412

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Refactor + add unit and smoke testing workflows. #412

wants to merge 3 commits into from

Conversation

JamesKunstle
Copy link
Contributor

This PR does two things:

  1. refactors the existing actions workflow for unit-test.yaml to call two new reusable workflows for starting and stopping an ec2 runner.
  2. adds a smoke-test.yaml workflow that's very similar to unit-test.yaml but calls a different tox+pytest path and requires a cuda runner.

@mergify mergify bot added CI/CD Affects CI/CD configuration testing Relates to testing ci-failure dependencies Pull requests that update a dependency file labels Jan 25, 2025
@JamesKunstle JamesKunstle force-pushed the add-feature-testing branch 2 times, most recently from 6ead130 to 85d8027 Compare January 25, 2025 02:33
@mergify mergify bot added ci-failure and removed ci-failure labels Jan 25, 2025
@JamesKunstle
updates /tests folder layout, adds test matrix and smoke test
22ffeaf 
Test groups are divided into three categories:
1) unit tests
2) smoke tests
3) benchmark tests

They each have a dedicated tox entrypoint.

Adds outer product of [FSDP, DeepSpeed] x [CPU offload, Not] test
matrix.

DEEPSPEED TESTS ARE BROKEN IN THIS COMMIT and are marked xFail- to be
fixed in another, later commit.

Signed-off-by: James Kunstle <[email protected]>
@JamesKunstle
create reusable workflows for starting/stopping ec2 runners
77ae91e 
starting/stopping self-hosted ec2 runners is common code that we can
move into separate, reusable workflows.

moved those steps into their own files and refactored `unit-tests.yaml`
to call them instead of inlining.

Signed-off-by: James Kunstle <[email protected]>
@JamesKunstle
adds smoke test workflow
36c446a 
users can dispatch a workflow that runs smoke tests against a selected
branch

Signed-off-by: James Kunstle <[email protected]>
@mergify mergify bot added ci-failure and removed ci-failure labels Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI/CD Affects CI/CD configuration ci-failure dependencies Pull requests that update a dependency file testing Relates to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JamesKunstle