Ap/async logger #58
Merged
Ap/async logger #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldopareja
force-pushed
the
ap/async_logger
branch
from
c766528
to
d4342a2
Compare
added 3 commits
June 21, 2024 15:50
|
@RobotSail @aldopareja, we really, REALLY can't merge PRs that fail the DCO check in CI. This is a legal requirement for how we accept contributions to the repos. |
russellb
reviewed
Jun 24, 2024
| @@ -7,7 +7,7 @@ torch>=2.3.0a0 | |||
| transformers>=4.41.2 | |||
| datasets>=2.15.0 | |||
| numba | |||
| numpy | |||
| numpy==1.26.4 | |||
There was a problem hiding this comment.
specific version pinning like this is very problematic as this gets included in a larger distribution. This should be removed ASAP
|
@russellb You are right about the DCO and version pinning, thank you for pointing it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.