requirements: Adjust numpy dependency range #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobotSail
reviewed
Jun 25, 2024
requirements.txt
Outdated
| @@ -7,7 +7,7 @@ torch>=2.3.0a0 | |||
| transformers>=4.41.2 | |||
| datasets>=2.15.0 | |||
| numba | |||
| numpy==1.26.4 | |||
| numpy>=1.26.4,<2.0.0 | |||
There was a problem hiding this comment.
Please change this line to:
Suggested change
| numpy>=1.26.4,<2.0.0 | |
| numpy<2 |
I believe the 1.26.4 was arbitrarily pinned, it just needs to be under 2.
There was a problem hiding this comment.
got it. I'm actually going to copy over what the CLI repo has, because it had some more specific reasons on versions
RobotSail
reviewed
Jun 25, 2024
According to comments on instructlab#61, numpy 2 doesn't work with this library right now. Instead of pinning to a specific 1.x version, allow a range up to, but not including 2.0.0. The specifics on the lower end come from what's used in `instructlab/instructlab`. Signed-off-by: Russell Bryant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to comments on #61, numpy 2 doesn't work with this library
right now. Instead of pinning to a specific 1.x version, allow a range
from a known working version up to, but not including 2.0.0.
Signed-off-by: Russell Bryant [email protected]