Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Pin netCDF4 to a version lower than 1.6. I've lost track of the issues talking about the problems of netCDF4 1.6.1, but downgrading solved the errors in all CI errors, but one. I'm not sure, but this could be the culprit issue : Unidata/netcdf4-python#1192
The
test_source.py::test_open_dataset_kerchunk
test is failing in a weird way. It seems that at some point, fsspec fails with aConnectionTimeoutError
, however, this error is not raised. Instead somehow replaces an object and the fsspec later tries to access an item of that object, this time raisingTypeError: 'ConnectTimeoutError' object is not subscriptable
.The
noaa-nwm-test-reference.json
file made reference to the S3 bucketnoaa-nwm-retro-v2.0-pds
and folderfull_physics
. I have not found this bucket by googling it. When trying to access the http endpoint of s3 directly, it failed. However, I did find this:https://registry.opendata.aws/nwm-archive/ . Was the old bucket simply renamed and reorganized? This was done in #480.
@andersy005 any ideas?
I replaced all reference of the old urls with a new one that imitates the one that works for me in the http browser, but it still fails.
Checklist