Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING guidelines to e.g. refer to new default branch #674

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

sadielbartholomew
Copy link
Contributor

Change Summary

Whilst skim reading the contributing guidelines to put in the PR #673 I noticed it referred to the master branch but the default branch is named main so I guess it was renamed but that page has not been updated accordingly. There are also some links which I have updated:

  • one which was not formatted properly to form a hyperlink, and also duplicated in terms of stating the URL, so I fixed it and removed the duplicate;
  • one which now leads to a page which is marked in capitals at the top as a warning 'OBSOLETE CONTENT This wiki has been archived and the content is no longer updated. Please visit git-scm.com/doc for up-to-date documentation.' so I thought I should also update that to an up-to-date equivalent.

Related issue number

Trivial docs page set of minor updates hence I have not raised an Issue first.

Checklist

  • [n/a] Unit tests for the changes exist
  • [n/a] Tests pass on CI
  • [n/a] Documentation reflects the changes where applicable

@mgrover1
Copy link
Collaborator

Sorry for the delay here @sadielbartholomew - taking a look at this today!

Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for the contribution!

@mgrover1 mgrover1 merged commit 0f2bbea into intake:main Jul 26, 2024
6 checks passed
@sadielbartholomew sadielbartholomew deleted the small-docs-updates branch July 29, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants