Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and publish wheels for python 3.11 #124

Closed
aris-aiven opened this issue Nov 16, 2022 · 14 comments
Closed

Build and publish wheels for python 3.11 #124

aris-aiven opened this issue Nov 16, 2022 · 14 comments

Comments

@aris-aiven
Copy link

Hi there, it would be great to have python 3.11 compatibility.

@gertjanwytynck
Copy link

Anyone got this one working on python 3.11.2?

@martindurant
Copy link
Member

I wonder what the use case is now for this library? Would people consider using cramjam instead?

@gertjanwytynck
Copy link

I need to use it for pymongo-compression..

I see this PR, when will it be merged?
#125

@martindurant
Copy link
Member

That PR doesn't cover the cffi path, which I don't actually understand, skipping tests to get the green mark :|

@cbini
Copy link

cbini commented Mar 16, 2023

@martindurant thanks for recommending cramjam. Unfortunately, I can't use that because fastavro depends exclusively on this library for using the snappy codec. It's probably possible to rewrite my avro read/write code to use the vanilla avro package, but that's a much bigger project.

@martindurant
Copy link
Member

@milesgranger , there seems little point in maintaining this snappy, and there are things about the build system I don't understand. Do you think we can make this a compatibility pseudo-package that just calls cramjam? Later, we can introduce a deprecation on import and eventually retire this package.

@milesgranger
Copy link

I think cramjam has been in use long enough to have exposed any egregious warts it might've had and I'm not planning on going anywhere. So would be pleased as pie to continue to support it. 👌

@martindurant
Copy link
Member

@milesgranger , the only missing I see is an equivalent to snappy.StreamDecompressor , which is the iterable counterpart to what cramjam.snappy.Compressor does. There is also a StreamCompressor which I think is identical to Compressor. Of course, this should be tested. I doubt either of these gets much use compared to compress/decompress, but it would be nice to support the whole current API.

@milesgranger
Copy link

Fair point. I'm casually working on some updates for cramjam lately anyway, so might be good to add that to the todo list. :)

@milesgranger
Copy link

FWIW, v2.7.0 released today has effectively the same StreamDecompressor

aris-aiven added a commit to Aiven-Open/rohmu that referenced this issue Aug 22, 2023
The python-snappy library is no longer maintained (see [1]). Cramjam is a drop-in replacement
that allows for a considerable speedup both in the compression and decompression
tasks. The relevant benchmark for snappy's framed format [2].

[1]: intake/python-snappy#124
[2]: https://github.com/milesgranger/pyrus-cramjam/blob/33c0516374fb9726ddcb82c5dfbe86be96d2cd35/cramjam-python/benchmarks/README.md
aris-aiven added a commit to Aiven-Open/rohmu that referenced this issue Aug 22, 2023
The python-snappy library is no longer maintained (see [1]). Cramjam is a drop-in replacement
that allows for a considerable speedup both in the compression and decompression
tasks. The relevant benchmark for snappy's framed format [2].

[1]: intake/python-snappy#124
[2]: https://github.com/milesgranger/pyrus-cramjam/blob/33c0516374fb9726ddcb82c5dfbe86be96d2cd35/cramjam-python/benchmarks/README.md
aris-aiven added a commit to Aiven-Open/rohmu that referenced this issue Aug 22, 2023
The python-snappy library is no longer maintained (see [1]). Cramjam is a drop-in replacement
that allows for a considerable speedup both in the compression and decompression
tasks. The relevant benchmark for snappy's framed format [2].

[1]: intake/python-snappy#124
[2]: https://github.com/milesgranger/pyrus-cramjam/blob/33c0516374fb9726ddcb82c5dfbe86be96d2cd35/cramjam-python/benchmarks/README.md
aris-aiven added a commit to Aiven-Open/rohmu that referenced this issue Aug 22, 2023
The python-snappy library is no longer maintained (see [1]). Cramjam is a drop-in replacement
that allows for a considerable speedup both in the compression and decompression
tasks. The relevant benchmark for snappy's framed format [2].

[1]: intake/python-snappy#124
[2]: https://github.com/milesgranger/pyrus-cramjam/blob/33c0516374fb9726ddcb82c5dfbe86be96d2cd35/cramjam-python/benchmarks/README.md
@gliptak
Copy link
Collaborator

gliptak commented Feb 2, 2024

#129

@gliptak
Copy link
Collaborator

gliptak commented Feb 23, 2024

@martindurant
Copy link
Member

^ this can be installed with

pip install --pre python-snappy

or by specifying the exact version desired.

@aris-aiven
Copy link
Author

Seeing versions 0.7.0 and 0.7.1 are available on PyPi, I'm closing this as completed.
Thanks a lot for your time and effort @martindurant @gliptak and @milesgranger for the awesome library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants