Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#54 sso with permissions #28

Merged
merged 18 commits into from
Jan 19, 2024
Merged

Feature/#54 sso with permissions #28

merged 18 commits into from
Jan 19, 2024

Conversation

Lyannic
Copy link
Contributor

@Lyannic Lyannic commented Dec 27, 2023

No description provided.

Lyannic added 17 commits December 14, 2023 12:04
@Lyannic
Roughly create separate PHP script to open Problem Selector with SSO
17cfdcf
@Lyannic
Remove MUMIE Task requirement from problem_selector.php
7713060
@Lyannic
Add LT api prefix to problem selector URL
f03bbcd
@Lyannic
Remove irrelevant param problemSelectorOrigin
d6edf16
@Lyannic
Use serverUrl of Lemon dev server
75958b7
@Lyannic
Read additional problem selector params
fc43b56
@Lyannic
Add missing PHPdoc to problem_selector.php
dc31d2c
@Lyannic
Apply naming convention to variable and function names
37263af
@Lyannic
Only allow SSO to Problem Selector when user has corresponding capabi…
c1d28ba 
…lity
@Lyannic
Use context id instead of course id
8090974
@Lyannic
Use camelCase for variable names in problem_selector.php
0d20d82
@Lyannic
Add i18n for capability mumie:ssotoproblemselector
8dd830b
@Lyannic
Add @Lecturer@ postfix to uers hash when doing SSO to Problem selector
903d031
@Lyannic
Make all variables in problem_selector.php lower case
f8fece2
@Lyannic
Use all lower case for request param names
c2ad564
@Lyannic
Reduce line length of open_problem_selector definition
cc58a1c
@Lyannic
Use all lower case for variable names in problem_selector.php
90a76f0
fsacha
fsacha reviewed Jan 3, 2024
View reviewed changes
classes/sso/hash/hashing_service.php Show resolved Hide resolved
classes/sso/hash/hashing_service.php Outdated Show resolved Hide resolved
classes/sso/user/mumie_user_service.php Show resolved Hide resolved
@Lyannic Lyannic marked this pull request as ready for review January 8, 2024 11:13
@dung238 dung238 self-requested a review January 19, 2024 16:21
@Lyannic Lyannic merged commit 33333db into dev Jan 19, 2024
2 checks passed
@Lyannic Lyannic deleted the feature/#54-sso-with-permissions branch January 19, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsacha fsacha fsacha left review comments

@dung238 dung238 dung238 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lyannic @fsacha @dung238