Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Deprecation Warnings for Php 8.1 #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Deprecation Warnings for Php 8.1 #34

wants to merge 1 commit into from

Conversation

Marvin-Kirch
Copy link

grafik

when using php 8.1 deprecation warnings are displayed in debug mode.

With this small fix there are no more warnings.

Lyannic
Lyannic requested changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@Lyannic Lyannic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Unfortunately, we also need to support PHP 7. mixed got introduced in PHP 8. See #27 for more details. We have another PR for this issue, but didn't manage to get the pipeline running for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lyannic Lyannic Lyannic requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Marvin-Kirch @Lyannic