Skip to content

Commit

Permalink
Preparing Release 1.4.5 (#37)
Browse files Browse the repository at this point in the history
* 19818 set grademax during grade_item_update

* 19818 removed debugging info

* WIP upgrade db to include maxgrade

* 19818 fixed migration

* 19818 removed migration and added to changelog

* updated changelog and version

* fixed typos

* 20031 make new window mode default (#6)

* 20031 make new-window-mode the default for new tasks

* Added function to display information box

* added travis config file

* try new push of travis

* 20129 fixed a bug where duedate and isGraded were not copied during duplication and backup (#7)

* 20213 changing a tasks problem should reset grades (#8)

* 20213 reset grades if problem is changed

* 20213 removed logs

* 20213 added note to tooltip that changing a problem lets to a grade reset

* updated codestyle

* 19487 implementing multi upload with drag and drop (#4)

* 19487 WIP implementing multi upload with dnd

* 19487 fixed namespace error for exceptions

* 19487 improved upload validation method

* 19487 fixed a bug, where admin choices for gradepool where ignored when importing tasks via d&d

* 19487 added german translation for new string

* 19487 added php docs

* 19487 removed logs

* updated codestyle

* Missing server configuration no longer disables js in mod_mumie form (#11)

Co-authored-by: Filip Sacha <[email protected]>

* Feature/#18600 external problem selector (#9)

* 18600 proof of concept

* 18600 first working prototype

* 18600 refactored problemSelectorController

* 18600 loggin incoming messages

* opener at local.mumie.net

* opening local.tobias.net as problemselector

* hopefully fixed cors errors

* 18600 send origin as param

* 18600 LMS Problem selector now works with local lemon

* changed url of problem selector

* bumped version

* Problem selector now works with lemon staging

* changed problem selector url to production instance

* Problem selector can be edited

* improved coding style

* formatted code

* Added system language param to lsm problem selector url. Passing values
to js as params.

* formatted (#13)

Co-authored-by: Filip Sacha <[email protected]>

* WIP removing problem drop down

* Updated changeListener for checkbox, so entire course can be selected as mumie task

* resolved errors

* removed unneccessary id param from custom html, to fix travis error

* wip

* Adjusted text input field size via css, to properly display task names.

* formatted

* link to entire course is displayed if link in courses-and-tasks.json is (#15)

* link to entire course is displayed if link in courses-and-tasks.json is
available

* removed one parentElement to fix the position of the course checkbox

* added hideIf to task_display_element and mumie_form_prb_selector_btn,
because the task name was displayed twice

* bug fix disabled element via js, cause there is a bug with native moodle html elements

* Fixed formatting for travis and correct a few typos

* Improved more formatting to fix travis error

Co-authored-by: Filip Sacha <[email protected]>
Co-authored-by: Tobias Goltz <[email protected]>

* Feature/#18600/task/#20770 link to entire course if link available (#16)

* link to entire course is displayed if link in courses-and-tasks.json is
available

* removed one parentElement to fix the position of the course checkbox

* added hideIf to task_display_element and mumie_form_prb_selector_btn,
because the task name was displayed twice

* bug fix disabled element via js, cause there is a bug with native moodle html elements

* Fixed formatting for travis and correct a few typos

* Improved more formatting to fix travis error

* Removed unused styles and fixed some typos

Co-authored-by: Filip Sacha <[email protected]>

* Form validation must't check whether taskurl is part of official server structure. It disables d&d import from MUMIE for lang other than german

* updated changelog, removed outdated params and fixed some spelling

* improved param names in problem selector request

* updated version

Co-authored-by: Filip Sacha <[email protected]>
Co-authored-by: fsacha <[email protected]>

* Selected language is now saved additionally in a hidden input because moodle ignores select-inputs with the 'hidden' attribute

* updated release date

* Added a tag to course view of mumie task to inform students about pas… (#19)

* Added a tag to course view of mumie task to inform students about passing requirements

* updated changelog

* added left margin to tags for MTasks in course view page

* fixed formatting errors

* Feature/#20985 extend due date (#20)

* WIP adding grading page

* WIP extend duedate for student

* wip display duedate form as modal

* WIP duedates can now be set in modal

* cleanup, info about general due date on extension-page, i18n

* bumped version

* WIP creating new table for duedate extensions during plugin upgrade

* Feature/#20985/#21411 use due date extension in gradesync (#22)

* added check for user dependent duedate

* checks if no user specific duedate added

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* resolved formatting

Co-authored-by: Filip Sacha <[email protected]>
Co-authored-by: root <[email protected]>

* Feature/#20985/#21417 add view mumie task button (#23)

* wip

* wip

* wip

* formatting, styling

* opens mumie task in new tab, styling button, rename button

* formatting

* done

* threads resolved

Co-authored-by: Filip Sacha <[email protected]>

* Feature/#20985/#21437 show and select submissions for grading (#21)

* WIP all submissions can now be seen by teachers and a submission can be selected to overwrite the gradebook entry

* Added i18n, teachers now see grading page when opening the activity

* fixed wrong boolean in default action for view

* added php docs and fixed some formatting

* Removed mocked xapi grade response for submissions

* fixed missspelled classname

* Submissions table now displays a short info, if no grade are available

* Simplified include_grade()

* fixed param type

* WIP fixing error where grades where not synced

* WIP fixed an issue where not all submissions where displayed

* added debug logging

* Removed debugging

* fixed duedate form not working

* WIP

* WIP fixing bug where grades cannot be overridden

* Fixed issue, where a teacher couldnt open a task

* fixed teachers not being able to opene mtasks

* WIP fixing grade validation during overrite

* WIP fixing grade validation during overrite

* WIP fixing grade validation during overrite

* WIP fixing grade validation during overrite

* WIP fixing grade validation during overrite

* WIP fixing grade validation during overrite

* WIP fixing grade validation during overrite

* WIP fixing grade validation during overrite

* Removed unnecessary classes for submissions html table

* Fixed some spelling issues and improved wording

* fixed param type in grade validater

* Open MUMIE Task button now is smaller

* default value for action is now set optional_params call

* extracted duplicated code into xapiToMoodleGradeTransformer

* Fixed an error, where xapi grade transformer had no return value

Co-authored-by: Filip Sacha <[email protected]>

* Try autoformatting php

* fixed formatting issues

* fixing formatting issues

* Update main.yml

* Update main.yml

* Update main.yml

* fixed more formatting

* mend

* Hopefully the last formatting fix

* adding phpdoc checker

* Fixed missing phpDocs and removed unneccessary context property form mumie_grader

* Fixed formatting error that was introduced when adding phpdocs

* Github actions should run on master branch

* display duedateextensions in courseview

* fiexed

* formatting

* Feature/#21607 due date in calendar (#25)

* General duedate is now saved, updated and deleted in calendar

* Calendar is now updated when adding, changing or deleting MTs and shows duedate extensions

* fixed issue, where extension events where not deleted when extension is revoked

* Updated changelog to include all changes to due date and calendar events. Also fixed wrong type in php doc

* extracted logic for individual calender entries into new class to improve code quality

* removed unnecessary type property and improved codestyle

Co-authored-by: fsacha <[email protected]>
Co-authored-by: Filip Sacha <[email protected]>
Co-authored-by: root <[email protected]>

* Feature/#21604 simultaneous editing of properties from different tasks (#26)

* wip

* done

* removed unnecessary sql requests

* formatting 1.0

* formatting 2.0

* formatting 3.0

* formatting 4.0

* resolved threads

* formatting

* removed unnecessary json

* more explicit access to the element

* revoked changes, causes error, will be done in refactoring

* Fixed bug for displaying grade tag. A course task has no grade item object.

* Fixed some minor codestyle/naming issues and wording

* fixed typos and whitespace issues

* fixed issue where multi edit section could not be collapsed

* fixed more spelling issues

* extracted onClickListeners in multiTaskEditController.init into dedicated functions to improve readability. Also renamed a few varaibles

* refactored selection array manipulation in multiTaskEditController to increase readability

* fixed an issue where tasksid could appear multiple times in the taskSelectionArray

* changed some html ids to avoid potential conflicts

* made minor changes to table headers in multi edit selection tables

* display info message, if no MT is available for multi edit

* changed some wording and improved look of multi edit selection tables

Co-authored-by: Filip Sacha <[email protected]>
Co-authored-by: Tobias Goltz <[email protected]>

* fixed spelling error in capabilities

* fixed error

* Multieditcontroller is now initialized correctly

* readability

* formatting

* formatting 2.0

* resolved threads

* Feature/#22053 add privacy provider (#30)

* export working

* delete works now

* WIP

* added test cases for privacy api

* fixed broken version file

* Fixed php docs and added german translation

* fixed some php docs and codestyle issues

* fixed more php docs and codestyle issues

* replaced deprecated function call array_key_exists

* fixing unit test

* updated changelog

* removed unused variables and made other minor adjustments after code review

* improved php docs and test comment

* streamlined naming for deadline in ui

* Added link to wiki to mod_form and prepared new release

* revmoved git merge annotations and grunted

* Update changelog.md

* Update changelog.md

* Update changelog.md

* Hot fixed a bug that appeared when the participant list on grading page was sorted by either due date extension or submissions

* Removed unnecessary travis config as we switched to github actions

* Feature/#23657 select ungraded problems (#34)

* Add logic to support selction of ungraded problems via problem selector

* Fixed a few issues with graded property. Cleaned up code.

* Fixed php code styling

* Updated js to ES6

* removed alert from js

* fixed whitespace issue

* fixed whitespace issue

* updated changelog

* Added styling for warning/info messages next to MT in course view for Moodle v3.11

* Create experiment.yml

* hopefully fixing installation error on mariadb

* Update main.yml

* Update main.yml

* only check with psql

mariadb has some config issues and will automatically fail

* Update main.yml

* Updated version and changelog for release

* Deleted experimental github actions files

* Bug/#25484 dnd imported m ts should be graded (#36)

* Fixed an issue where imported MTs where always processed as ungraded

* Fixed codestyle where line was too long

Co-authored-by: fsacha <[email protected]>
Co-authored-by: Filip Sacha <[email protected]>
Co-authored-by: root <[email protected]>
  • Loading branch information
4 people authored Sep 1, 2021
1 parent d531b29 commit 278f565
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 3 deletions.
4 changes: 4 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

All important changes to this plugin will be documented in this file.

## [v1.4.5] - 2021-09-01
### Fixed
- Fixed an issue, where adding MUMIE Tasks via drag&drop did not create entries in the Moodle Gradebook.

## [v1.4.4] - 2021-07-29
### Added
- Added possibility to select *ungraded* articles, chapters and courses in problem selector.
Expand Down
1 change: 1 addition & 0 deletions classes/mumie_dndupload_processor.php
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ private function create_mumie_from_uploadinstance($uploadinstance) {
$mumie->points = 100;
$mumie->name = \mod_mumie\locallib::get_default_name($uploadinstance) ?? $uploadinstance->name;
$mumie->privategradepool = $this->gradepoolsettings;
$mumie->isgraded = $uploadinstance->isGraded;
return $mumie;
}

Expand Down
6 changes: 5 additions & 1 deletion lib.php
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,11 @@ function mumie_cm_info_view(cm_info $cm) {
$info .= html_writer::tag('p', $content, array('class' => 'tag-info tag mumie_tag badge badge-info '));
}
if (!isset($mumie->privategradepool)) {
$info .= html_writer::tag('p', get_string('mumie_tag_disabled', 'mod_mumie'), array('class' => 'tag-warning tag mumie_tag badge badge-warning'))
$info .= html_writer::tag(
'p',
get_string('mumie_tag_disabled', 'mod_mumie'),
array('class' => 'tag-warning tag mumie_tag badge badge-warning')
)
. html_writer::tag(
'span',
get_string('mumie_tag_disabled_help', 'mod_mumie')
Expand Down
4 changes: 2 additions & 2 deletions version.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@

defined('MOODLE_INTERNAL') || die;

$plugin->version = 2021072900; // The current module version (Date: YYYYMMDDXX).
$plugin->version = 2021090100; // The current module version (Date: YYYYMMDDXX).
$plugin->component = 'mod_mumie'; // Full name of the plugin (used for diagnostics).
$plugin->requires = 2020061500;
$plugin->release = "v1.4.4";
$plugin->release = "v1.4.5";
$plugin->maturity = MATURITY_STABLE;
$plugin->dependencies = array(
'auth_mumie' => 2021031200,
Expand Down

0 comments on commit 278f565

Please sign in to comment.