Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#33667 deadlines in xapi requests #58

Merged
merged 24 commits into from
Oct 19, 2023
Merged

Feature/#33667 deadlines in xapi requests #58

merged 24 commits into from
Oct 19, 2023

Conversation

jtgoltz
Copy link
Contributor

@jtgoltz jtgoltz commented Aug 2, 2023

No description provided.

tobias added 21 commits August 1, 2023 14:29
Create new class playload that holds payload for grade sync requests
86bf9fd
Defined context classes to include information about deadlines in gra…
75c0bd2 
…de sync requests
extracted logic to create/send xapi requests into new xapi_request cl…
ce035fb 
…ass to clean up gradesync.php
WIP Add context to grade sync request
a153b30
WIP Add context to grade sync request
4e948cf
Implemented logic for context_provider::has_context
38ae3d7
Added/fixed typing
0f4c488
Fixed some whitespace formatting
15b4a67
Added moodle boiler plate
a6e00c8
fixed illegal use of camel case
0b81c60
fixed some whitespace issues
febb2ab
Extracted logic to get mumie_users in gradesync::get_mumie_grades int…
91684aa 
…o new method
Removed some code duplicates
469e16f
fixed missing camel case in xapi_request
d977cb6
WIP fixing issue where
e8767d5
moved get_mumie_id to locallib so that it can be used by multiple cla…
7155330 
…sses
Added missing php docs
45738d0
Removed unnecessary local variable
91416ad
Renamed method to clearly indicate the return type.
f238cf7
Merge branch 'dev' into feature/#33667-deadlines-in-xapi-requests
bc2b5cf 
# Conflicts:
#	gradesync.php
#	locallib.php
Added missing php docs
fd96675
@jtgoltz jtgoltz changed the title Draft: Feature/#33667 deadlines in xapi requests Feature/#33667 deadlines in xapi requests Aug 3, 2023
Lyannic
Lyannic requested changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@Lyannic Lyannic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did my best, but please keep in mind that I don't know anything about the plugin, Moodle and PHP.

classes/grades/synchronization/context/context_provider.php Outdated Show resolved Hide resolved
classes/grades/synchronization/context/context_provider.php Outdated Show resolved Hide resolved
classes/grades/synchronization/context/object_context.php Show resolved Hide resolved
classes/grades/synchronization/xapi_request.php Outdated Show resolved Hide resolved
classes/grades/synchronization/xapi_request.php Outdated Show resolved Hide resolved
gradesync.php Outdated Show resolved Hide resolved
classes/grades/synchronization/context/context_provider.php Outdated Show resolved Hide resolved
@fsacha fsacha merged commit 44aa210 into dev Oct 19, 2023
2 checks passed
@fsacha fsacha deleted the feature/#33667-deadlines-in-xapi-requests branch October 19, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dung238 dung238 dung238 left review comments

@fsacha fsacha fsacha left review comments

@Lyannic Lyannic Lyannic requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jtgoltz @Lyannic @fsacha @dung238