Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Stripe 11 #165

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Add support for Stripe 11 #165

merged 1 commit into from
Apr 22, 2024

Conversation

abepark01
Copy link
Contributor

Add support for the Stripe v11 gem.

@schinery
Copy link
Contributor

@rmm5t are you able to give this a look? 🙏🏻

(Only asking as you merged the previous Stripe bumps)

Copy link
Member

@rmm5t rmm5t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please take note on the comment about the abundance of changes in the changelog. For future reference, at least. Thank you.


### 0.1.0 (June 24, 2012)
* Initial release

- Initial release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[CONCERN] I'm going to let this slide for the sake of time and the fact that it's effectively benign, but please never do this (reformatting of unrelated things) in a PR related to something else.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmm5t Thank you for the note! My editor autoformatted the text and I didn't realize it until afterward.

@rmm5t rmm5t merged commit 4d0f9f7 into integrallis:master Apr 22, 2024
45 checks passed
@rmm5t
Copy link
Member

rmm5t commented Apr 22, 2024

v2.9.0 released:

https://rubygems.org/gems/stripe_event/versions/2.9.0

Thank you! 🍻

@schinery
Copy link
Contributor

Thanks @rmm5t 🙌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants