Skip to content

Commit

Permalink
selftests/bpf: More endpoints for endpoint_init
Browse files Browse the repository at this point in the history
This patch adds two more test addresses ADDR_3 and ADDR_4, and adds a new
helper address_init() to initialize all these addresses.

Add a new parameter "endpoints" for endpoint_init() to control how many
endpoints are used for the tests. This makes it more flexible. Update the
parameters of endpoint_init() in test_subflow().

Signed-off-by: Geliang Tang <[email protected]>
  • Loading branch information
Geliang Tang authored and intel-lab-lkp committed Oct 9, 2024
1 parent 514c07e commit 5220d95
Showing 1 changed file with 41 additions and 5 deletions.
46 changes: 41 additions & 5 deletions tools/testing/selftests/bpf/prog_tests/mptcp.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
#define NS_TEST "mptcp_ns"
#define ADDR_1 "10.0.1.1"
#define ADDR_2 "10.0.1.2"
#define ADDR_3 "10.0.1.3"
#define ADDR_4 "10.0.1.4"
#define PORT_1 10001
#define WITH_DATA true
#define WITHOUT_DATA false
Expand Down Expand Up @@ -351,22 +353,56 @@ static void test_mptcpify(void)
close(cgroup_fd);
}

static int endpoint_init(char *flags)
static int address_init(void)
{
SYS(fail, "ip -net %s link add veth1 type veth peer name veth2", NS_TEST);
SYS(fail, "ip -net %s addr add %s/24 dev veth1", NS_TEST, ADDR_1);
SYS(fail, "ip -net %s link set dev veth1 up", NS_TEST);
SYS(fail, "ip -net %s addr add %s/24 dev veth2", NS_TEST, ADDR_2);
SYS(fail, "ip -net %s link set dev veth2 up", NS_TEST);
if (SYS_NOFAIL("ip -net %s mptcp endpoint add %s %s", NS_TEST, ADDR_2, flags)) {

SYS(fail, "ip -net %s link add veth3 type veth peer name veth4", NS_TEST);
SYS(fail, "ip -net %s addr add %s/24 dev veth3", NS_TEST, ADDR_3);
SYS(fail, "ip -net %s link set dev veth3 up", NS_TEST);
SYS(fail, "ip -net %s addr add %s/24 dev veth4", NS_TEST, ADDR_4);
SYS(fail, "ip -net %s link set dev veth4 up", NS_TEST);

return 0;
fail:
return -1;
}

static int endpoint_add(char *addr, char *flags)
{
return SYS_NOFAIL("ip -net %s mptcp endpoint add %s %s", NS_TEST, addr, flags);
}

static int endpoint_init(char *flags, u8 endpoints)
{
int ret = -1;

if (!endpoints || endpoints > 4)
goto fail;

if (address_init())
goto fail;

if (SYS_NOFAIL("ip -net %s mptcp limits set add_addr_accepted 4 subflows 4",
NS_TEST)) {
printf("'ip mptcp' not supported, skip this test.\n");
test__skip();
goto fail;
}

return 0;
if (endpoints > 1)
ret = endpoint_add(ADDR_2, flags);
if (endpoints > 2)
ret = ret ?: endpoint_add(ADDR_3, flags);
if (endpoints > 3)
ret = ret ?: endpoint_add(ADDR_4, flags);

fail:
return -1;
return ret;
}

static void wait_for_new_subflows(int fd)
Expand Down Expand Up @@ -452,7 +488,7 @@ static void test_subflow(void)
if (!ASSERT_OK_PTR(nstoken, "create_netns: mptcp_subflow"))
goto skel_destroy;

if (endpoint_init("subflow") < 0)
if (endpoint_init("subflow", 2) < 0)
goto close_netns;

run_subflow();
Expand Down

0 comments on commit 5220d95

Please sign in to comment.