policy: compare dst and src when op is greater_or_equal #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the operation of a property in policy is greater or equal and the reference value if `self`, we should compare between dst and src, otherwise the only qualified value will be equal to `self`. Since MigTD-dst always start a TLS server and MigTD-src always start a TLS client, we can distinguish between migtd-s and d in this way when verifying the policy. Signed-off-by: Jiaqi Gao <[email protected]>
|
@liuw1 , do we have integration test need to fix or add? |
Merged
jyao1
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the operation of a property in policy is greater or equal and the reference value if
self, we should compare between dst and src, otherwise the only qualified value will be equal toself.Since MigTD-dst always start a TLS server and MigTD-src always start a TLS client, we can distinguish between migtd-s and d in this way when verifying the policy.
Fix: #22