Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable trivy scan in CI #276

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Enable trivy scan in CI #276

merged 1 commit into from
Jul 24, 2024

Conversation

liuw1
Copy link
Contributor

@liuw1 liuw1 commented Jul 23, 2024

No description provided.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@liuw1 liuw1 marked this pull request as draft July 23, 2024 05:26
@liuw1 liuw1 force-pushed the enable-trivy-scan branch 4 times, most recently from 3180fc1 to 2877268 Compare July 23, 2024 07:54
@liuw1 liuw1 marked this pull request as ready for review July 23, 2024 07:55
@liuw1 liuw1 marked this pull request as draft July 23, 2024 08:28
with:
scan-type: 'fs'
scanners: 'vuln'
ignore-unfixed: true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ignore unfixed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

submodules: recursive

- name: Run Trivy vulnerability scanner
uses: aquasecurity/trivy-action@7b7aa264d83dc58691451798b4d117d53d21edfe

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why use this commit( 2 years ago)? why not use the latest one (0.24.0 2weeks ago)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, updated.

@liuw1 liuw1 marked this pull request as ready for review July 23, 2024 13:18
@jyao1 jyao1 merged commit 249ce4c into intel:main Jul 24, 2024
18 checks passed
@liuw1 liuw1 deleted the enable-trivy-scan branch September 19, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants