Switch to offical release rustls and add no_std support
#302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaojiaqi7
force-pushed
the
0924/support_no_std_rustls
branch
from
004150b
to
a1eeb98
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gaojiaqi7
force-pushed
the
0924/support_no_std_rustls
branch
3 times, most recently
from
2f32b27
to
11a24a9
Compare
rustls provides `Unbuffered` implementations of server and client connections that can be used in `no_std`. This patch implements two helper struct named `TlsServerConnection` and `TlsClientConnection` which provide much simpler interfaces. Crate `sys_time` is used to realize a `TimeProvider` and `rust-std-stub` is kept to provide `io::Read` and `io::Write` traits. Signed-off-by: Jiaqi Gao <[email protected]>
As we no longer need to maintain the patches for rustls, remove the submodule and patch file. Signed-off-by: Jiaqi Gao <[email protected]>
gaojiaqi7
force-pushed
the
0924/support_no_std_rustls
branch
from
11a24a9
to
e5d0cab
Compare
The binary size is increasing after upgrading rustls dependency, the current image configuration does not have enough space to hold debug migtd binary. Setting the strip as true in dev profile helps us decrease the binary size. This can be recovered after large payload is supported by td-shim. Signed-off-by: Jiaqi Gao <[email protected]>
jyao1
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should close #297