Build fixes and logging of encoded frames #171
Conversation
Fix linking to libmfx to be for the shared library. Fix meson build. Signed-off-by: Eero Tamminen <[email protected]> Signed-off-by: Ukri Niemimuukko <[email protected]>
Add log output from frame encoding. Signed-off-by: Ukri Niemimuukko <[email protected]>
This adds gstreamer-1.0 as the install directory. Signed-off-by: Ukri Niemimuukko <[email protected]>
|
@SiewHoon perhaps if this passes the tests this could be merged? |
There was a problem hiding this comment.
This "cmake, meson: build fixes" can not be accepted. The code fixed in meson.build that removed mfx_home, it will break build currently support in closed source MSDK library.
But about the shared libary fixed, we can accept it. Need you go rework the code fixed.
|
I will rejected this pull request. |
So basically you're saying that closed source MSDK is broken (doesn't support e.g. CI builds where each new build is done to a separate directory). Why you prefer your build succeeding against that in open source Gstreamer plugin, instead of against the open source MSDK? Could you add a link to a bug for the closed source MSDK, so that it can be tracked when they fix this? (It should be easy to fix, as they can take pkg-config support from the open source MSDK.) |
|
I didn't against Gstreamer plugin or MSDK library. I can't straight accept this solution and go broken the existing software support already shipped out. That patch didn't come out with a proper right solution. Now I already fixed it. I will merge it after done code review. Here is the code fixed and verify it: |
|
Yes, fallback to MFX_HOME in case MSDK isn't otherwise found is better. |
Ref:
#149 (although fix is limited to gstreamer-1.0 just like cmake is)
#148
#146