Extend FreeBSD conditional about byte ordering to NetBSD #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NetBSD has the same byte-ordering idioms as FreeBSD. Signed-off-by: Greg Troxel <[email protected]>
|
This PR is already pushed, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetBSD has the same byte-ordering idioms as FreeBSD.
With this, the code builds as a python-isal submodule. (Without, it takes the Linux path and fails because the Linux byteswap.h header is not present.)
Surely OpenBSD would also use these includes, but I don't have an OpenBSD environment handy to test. I'm happy to add OpenBSD if you want (were it my project I would), but I don't know your conventions for testing of changes.