-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
va: limit to VAProfileAV1Profile2_420 #832
base: master
Are you sure you want to change the base?
Conversation
Some hardwares do not support a full set of AV1 profile2, in this case use a subset instead. At the moment, VAProfileAV1Profile2_420 is for supporting 12-bit 4:2:0. Signed-off-by: David (Ming Qiang) Wu <[email protected]>
this is to address the issue in #828 |
@XinfengZhang, any concern about this patch? please let me know I can take a look. |
wondering if this change can be merged? Am I missing something? |
I am ok to merge it , but still not understand why profile + vaSurfaceAttrib could not report the restriction, such as 12bit 422only could use profile2+P010 format. of course, it will be more complex than current solution. |
OK - I will see if I can find something with profile + vaSurfaceAttrib. I think there could be a reporting issue (vainfo) as it cannot show 420only if we did not define a profile for it. (but I need to look into more details to be sure). |
suppose next release will happened by end of this year. I am thinking whether there are similar problem with other codec, and whether we need to use "profile + surfaceAttrib" to keep behavior consistent. just like AV1 profile0, how to clarify driver support monochrome or not? ho to differentiate driver support 444 8bit or 444 10bit for AV1 profile1? and suppose there are also some problem with VP9. so, both solution is ok to me, feel free to ping me to merge current PR. |
Some hardwares do not support a full set of AV1 profile2, in this case use a subset instead. At the moment, VAProfileAV1Profile2_420 is for supporting 12-bit 4:2:0.