Skip to content

Commit

Permalink
Fix failed 4k videowalll test case in Gen12 platform
Browse files Browse the repository at this point in the history
Fix failed 4k video wall test case from 16CH video only show
1CH output in RPL-P platform. This issue has been fixed in MTL
platform before.

platform: TGL/ADL/RPL

Signed-off-by: Chan, Xu Pian <[email protected]>
Signed-off-by: Lim Siew Hoon <[email protected]>
  • Loading branch information
SiewHoon committed Aug 2, 2024
1 parent 68edce6 commit 9fdc482
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6784,6 +6784,13 @@ bool CompositeState::BuildFilter(

for (i = 0; (i < (int)pCompParams->uSourceCount) && (iMaxFilterSize > 0); i++)
{
if (i > 0)
{
if (!RECT1_CONTAINS_RECT2(pCompParams->pSource[0]->rcDst, pCompParams->pSource[i]->rcDst))
{
pFilter->forceToTargetColorSpace = true;
}
}
pSrc = pCompParams->pSource[i];

//--------------------------------
Expand Down Expand Up @@ -8154,4 +8161,4 @@ bool CompositeState::IsSamplerIDForY(
return true;
}
return false;
}
}
18 changes: 5 additions & 13 deletions media_driver/linux/common/vp/ddi/media_libva_vp.c
Original file line number Diff line number Diff line change
Expand Up @@ -1148,7 +1148,7 @@ DdiVp_SetProcPipelineParams(

// Background Colorfill
// According to libva definition, if alpha in output background color is zero, then colorfill is not needed
if ((pPipelineParam->output_background_color >> 24) != 0 || pVpHalTgtSurf->ColorSpace == CSpace_sRGB)
if ((pPipelineParam->output_background_color >> 24) != 0)
{
if (pVpHalRenderParams->pColorFillParams == nullptr)
{
Expand All @@ -1157,18 +1157,10 @@ DdiVp_SetProcPipelineParams(

DDI_CHK_NULL(pVpHalRenderParams->pColorFillParams, "Null pColorFillParams.", VA_STATUS_ERROR_UNKNOWN);

if (pVpHalTgtSurf->ColorSpace == CSpace_sRGB && (pPipelineParam->output_background_color >> 24) == 0)
{
// set color space for sRGB output
pVpHalRenderParams->pColorFillParams->CSpace = CSpace_sRGB;
}
else
{
// set background colorfill option
pVpHalRenderParams->pColorFillParams->Color = pPipelineParam->output_background_color;
pVpHalRenderParams->pColorFillParams->bYCbCr = false;
pVpHalRenderParams->pColorFillParams->CSpace = CSpace_sRGB;
}
// set background colorfill option
pVpHalRenderParams->pColorFillParams->Color = pPipelineParam->output_background_color;
pVpHalRenderParams->pColorFillParams->bYCbCr = false;
pVpHalRenderParams->pColorFillParams->CSpace = CSpace_sRGB;
}else
{
MOS_FreeMemAndSetNull(pVpHalRenderParams->pColorFillParams);
Expand Down

0 comments on commit 9fdc482

Please sign in to comment.