Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

ROS ov2.0 #195

Open
wants to merge 41 commits into
base: ros
Choose a base branch
from
Open

ROS ov2.0 #195

wants to merge 41 commits into from

Conversation

ChloeWu1
Copy link

@ChloeWu1 ChloeWu1 commented Nov 2, 2022

No description provided.

@ChloeWu1 ChloeWu1 changed the title Noetic ov2022.1 ROS ov2。0 Nov 2, 2022
@ChloeWu1 ChloeWu1 changed the title ROS ov2。0 ROS ov2.0 Nov 2, 2022
# This file can be used with the --list option of the model downloader.
face-detection-adas-0001
age-gender-recognition-retail-0013
emotions-recognition-retail-0003

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no found the xml: face-reidentification-retail-0095.xml
if it is need.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and the xml vehicle-license-plate-detection-barrier-0123.xml

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

&& rm -rf /var/lib/apt/lists/*

# other dependencies
RUN apt-get update && apt-get install -y python3-pip && python3 -m pip install -U \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
the libcabera-gtk* would be install, else the pipeline_face_reidentification.launch would be fail.
apt-get install libcanberra-gtk*

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

* Before launch, check the parameter configuration in ros_openvino_toolkit/sample/param/xxxx.yaml, make sure the paramter like model path, label path, inputs are right.
* run face detection sample code input from StandardCamera.
```
roslaunch vino_launch pipeline_people.launch

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According the ducument the path such as xml image and labels etc in the yaml file that need your adjustment like ros2_openvino_toolkit.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

sudo cp ~/catkin_ws/src/ros_openvino_toolkit/data/labels/emotions-recognition/FP32/emotions-recognition-retail-0003.labels /opt/openvino_toolkit/models/emotions-recognition/output/intel/emotions-recognition-retail-0003/FP16/
sudo cp ~/catkin_ws/src/ros_openvino_toolkit/data/labels/face_detection/face-detection-adas-0001.labels /opt/openvino_toolkit/models/face_detection/output/intel/face-detection-adas-0001/FP32/
sudo cp ~/catkin_ws/src/ros_openvino_toolkit/data/labels/face_detection/face-detection-adas-0001.labels /opt/openvino_toolkit/models/face_detection/output/intel/face-detection-adas-0001/FP16/
sudo cp ~/catkin_ws/src/ros_openvino_toolkit/data/labels/object_detection/vehicle-license-plate-detection-barrier-0106.labels /opt/openvino_toolkit/models/vehicle-license-plate-detection/output/convert/intel/vehicle-license-plate-detection-barrier-0106/FP32

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is used FP16/vehicle-license-plate-detection-barrier-0106.labels at the pipeline_vehicle_detection.yaml. but there are FP32

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@@ -90,7 +90,7 @@ class ModelAttribute
slog::info << "--------------------------------" << slog::endl;
}

virtual bool updateLayerProperty(const InferenceEngine::CNNNetwork&)
virtual bool updateLayerProperty(std::shared_ptr<ov::Model>&)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If leave the const is better?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

docker/Dockerfile Show resolved Hide resolved
"variant": "cpp",
"bit": "cpp"
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No newline at the end.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

semantic-segmentation-adas-0001
mobilenet-ssd
deeplabv3
face-reidentification-retail-0095.xml

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, it should be
face-reidentification-retail-0095 and
vehicle-license-plate-detection-barrier-0123.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks.

Copy link
Contributor

@LewisLiuPub LewisLiuPub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please evaluate my comments and sync them with ROS2 version.

# ENV FTP_PROXY="your_proxy"

# maintainer information
LABEL maintainer="Jiawei Wu <[email protected]>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to label the author info: LABEL author="Jiawei Wu [email protected]"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@@ -0,0 +1,82 @@
# ros openvino toolkit env master ec5b9b9716e4

ARG ROS_VERSION
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename ROS_VERSION -->ROS_PRE_INSTALLED_PKG?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.


ARG ROS_VERSION
FROM osrf/ros:${ROS_VERSION}
ARG VERSION
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update these 3 lines above as:
ARG VERSION=noetic
ARG ROS_PRE_INSTALLED_PKG=${VERSION}-desktop-full
FROM osrf/ros:${ROS_PRE_INSTALLED_PKG}

```
cd ~/ros_openvino_toolkit/docker/Dockerfile
vi ~/ros_openvino_toolkit/docker/Dockerfile
docker build --build-arg ROS_VERSION=<EXPECT_ROS_BASE_IMAGE> --build-arg VERSION=<EXPECT_ROS_VERSION> --build-arg "HTTP_PROXY=set_your_proxy" -t ros_openvino_202201 .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ROS_VERSION and VERSION, quite similar, rename it.
  • what if we always install xxxx-desktop-full? making ROS_VERSION optional in the command.

WORKDIR /root/catkin_ws/src
RUN git init && git clone -b ros https://github.com/intel/ros_openvino_toolkit \
&& git clone https://github.com/intel/object_msgs.git \
&& git clone -b ${VERSION} https://github.com/ros-perception/vision_opencv.git \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cv_bridge and realsense-ros should be install by "apt install xxxx"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed. No need to install.

requests \
&& apt-get install -y --no-install-recommends libboost-all-dev
WORKDIR /usr/lib/x86_64-linux-gnu
RUN ln -sf libboost_python-py36.so libboost_python37.so
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't link between different versions.
We should find the root cause, then find the true implementation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

&& git clone https://github.com/intel/object_msgs.git \
&& git clone -b ${VERSION} https://github.com/ros-perception/vision_opencv.git \
&& git clone -b ros1-legacy https://github.com/IntelRealSense/realsense-ros.git
&& git clone https://github.com/intel/object_msgs.git

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove the git of vision_opencv and realsense?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No dependency on this two package.

@@ -1,13 +1,13 @@
Pipelines:
- name: object
inputs: [Video]
input_path: /home/ubuntu20/jiawei/ros-ov/ros_openvino_ws/src/ros_openvino_toolkit/data/car_cut.mp4
input_path: to/be/set/video_path
infers:
- name: ObjectDetection
model: /opt/openvino_toolkit/models/public/vehicle-license-plate-detection-barrier-0123/FP16/vehicle-license-plate-detection-barrier-0123.xml

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The model is vehicle-license-plate-detection-barrier-0123.xml, but label is vehicle-license-plate-detection-barrier-0106.labels

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as ov2021.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants