Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Application Emoji #1742

Merged
merged 5 commits into from
Jan 3, 2025
Merged

feat: Add support for Application Emoji #1742

merged 5 commits into from
Jan 3, 2025

Conversation

silasary
Copy link
Member

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

New discord feature, applications can host emoji, rather than storing them in guilds.

Changes

  • Added methods to Application for interacting with App Emoji
  • Modifed PartialEmoji to allow for emoji without a guild_id
  • Added missing available flag to PartialEmoji (This is technically unrelated, but I was in there)

Related Issues

Closes #1723

Test Scenarios

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

@silasary silasary mentioned this pull request Nov 19, 2024
Copy link
Member

@AstreaTSS AstreaTSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went ahead and fixed all of the issues I could find. Seems to be working now.

@silasary
Copy link
Member Author

silasary commented Jan 3, 2025

Appreciate it 😁

@silasary silasary merged commit caae85b into unstable Jan 3, 2025
9 of 12 checks passed
@silasary silasary deleted the app-emoji branch January 3, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants