Remove authorization request for notifications from app app delegate #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josh- you'll need to update to the latest master branch in order to merge this PR |
josh-
force-pushed
the
ios-app-delegate-remove-request-notification-permission
branch
from
a3db412
to
5be2b53
Compare
|
Done - thanks @Br1an-Boyle |
auto-merge was automatically disabled
May 29, 2024 23:29
Head branch was pushed to by a user without write access
josh-
force-pushed
the
ios-app-delegate-remove-request-notification-permission
branch
from
5be2b53
to
84c8a94
Compare
|
@liutingdu just rebased but looks like that disabled auto merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using the Intercom React Native SDK on iOS, users are prompted to enable notification permissions as soon as a the app is launched, as a result of the SDK injecting a call to
requestAuthorizationWithOptions(doc here) in the app delegate.This contravenes the recommendation in the README to manually request permissions from the user:
As such, this PR removes the call to
requestAuthorizationWithOptions, so SDK consumers can instead request permissions at the time that is appropriate to their app (eg. in an onboarding carousel)