Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor images #260

Merged
merged 3 commits into from
Oct 12, 2018
Merged

Refactor images #260

merged 3 commits into from
Oct 12, 2018

Conversation

oskarrough
Copy link
Member

@oskarrough oskarrough commented Oct 10, 2018

This PR closes #161. It does so by

  • removing our image model
  • replacing channel.images (hasMany) with channel.image (string)

It requires a node.js script that takes the newest image on each channel and puts the id as channel.image. I already ran this on staging but did not push the script anywhere.

TO PUT IT LIVE

Related:

internet4000/radio4000-api-node-firebase#8
internet4000/radio4000-api-node-firebase#7
#248

@oskarrough oskarrough requested a review from 4www October 10, 2018 09:38
@oskarrough oskarrough merged commit 64eb5cd into master Oct 12, 2018
@oskarrough oskarrough deleted the refactor-images branch October 12, 2018 08:24
@4www
Copy link
Contributor

4www commented Oct 15, 2018

Let's take care, as now that this is merged to master, the next time we merge to production we will have conflicts with how the player handles images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image refactoring in the database
2 participants