Remove type selector from subject tag edit page

internetarchive · Sep 10, 2024 · 80d1541 · 80d1541
1 parent 8f47922
commit 80d1541
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 15 deletions.
diff --git a/openlibrary/templates/type/tag/edit.html b/openlibrary/templates/type/tag/edit.html
@@ -14,7 +14,7 @@ <h1>$_("Edit Tag")</h1>
 <div id="contentBody">
 
     <form id="edittag" name="edit" method="post" action="" class="olform">
-        $:render_template("type/tag/tag_form_inputs", tag_name=page.name, tag_type=page.tag_type, tag_description=page.tag_description, fkey=page.fkey, body=page.body)
+        $:render_template("type/tag/tag_form_inputs", tag_name=page.name, tag_type=page.tag_type, tag_description=page.tag_description, fkey=page.fkey, body=page.body, show_type_picker=False)
         <div class="clearfix"></div>
 
         <div class="formElement bottom">

diff --git a/openlibrary/templates/type/tag/tag_form_inputs.html b/openlibrary/templates/type/tag/tag_form_inputs.html
@@ -1,4 +1,4 @@
-$def with (tag_name='', tag_type='', tag_description='', fkey=None, body='')
+$def with (tag_name='', tag_type='', tag_description='', fkey=None, body='', show_type_picker=True)
 
 <div class="formElement">
     <div class="label">
@@ -40,17 +40,18 @@
     </div>
 </div>
 
-<div class="formElement">
-    <div class="label"><label for="tag_type">$_("Tag type")</label></div>
-    <div class="input">
-        <select name="tag_type" id="tag_type" required>
-            <option value="">$_("Select")</option>
-            $ tag_types = get_tag_types()
-            $for t_type in tag_types:
-                $if t_type == tag_type:
-                    <option value="$t_type" selected>$t_type</option>
-                $else:
-                    <option value="$t_type">$t_type</option>
-        </select>
+$if show_type_picker:
+    <div class="formElement">
+        <div class="label"><label for="tag_type">$_("Tag type")</label></div>
+        <div class="input">
+            <select name="tag_type" id="tag_type" required>
+                <option value="">$_("Select")</option>
+                $ tag_types = get_tag_types()
+                $for t_type in tag_types:
+                    $if t_type == tag_type:
+                        <option value="$t_type" selected>$t_type</option>
+                    $else:
+                        <option value="$t_type">$t_type</option>
+            </select>
+        </div>
     </div>
-</div>