Merge pull request #9761 from Souvik-Cyclic/9629/fix/add-alt-attributes

Add [alt] attributes to images
internetarchive · Sep 5, 2024 · f4222d3 · f4222d3
2 parents d8f3a8e + 9741d29
commit f4222d3
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 6 deletions.
diff --git a/openlibrary/i18n/messages.pot b/openlibrary/i18n/messages.pot
@@ -7308,6 +7308,10 @@ msgstr[1] ""
 msgid "Related Books"
 msgstr ""
 
+#: EditionNavBar.html
+msgid "Go to next section"
+msgstr ""
+
 #: Follow.html
 msgid "UnfollowFollow"
 msgstr ""

diff --git a/openlibrary/macros/EditionNavBar.html b/openlibrary/macros/EditionNavBar.html
@@ -32,7 +32,7 @@
     </li>
   </ul>
   $if not desktop_only:
-    <span class="nav-arrow">
-      <img src="/static/images/nav-arrow.svg" role="img">
-    </span>
+    <button class="nav-arrow" title="$_('Go to next section')">
+      <img src="/static/images/nav-arrow.svg" alt="">
+    </button>
 </span>
diff --git a/openlibrary/templates/account/view.html b/openlibrary/templates/account/view.html
@@ -47,7 +47,7 @@ <h1 class="details-title">$header_title</h1>
             $set_share_links(url=request.canonical_url, title=header_title, view_context=ctx)
             $if ctx.get('share_links'):
               $ share_str = _('Share')
-              $ share_content = '<a class="cta-btn cta-btn--unstyled share-modal-link icon-link" href="javascript:;" data-ol-link-track="MyBooksModalLinkClick|ShareIcon"><img class="icon-link__image" src="/static/images/icons/share.svg" width="20"> %s</a>' % share_str
+              $ share_content = '<a class="cta-btn cta-btn--unstyled share-modal-link icon-link" href="javascript:;" data-ol-link-track="MyBooksModalLinkClick|ShareIcon"><img class="icon-link__image" src="/static/images/icons/share.svg" width="20" alt=""> %s</a>' % share_str
               $ page_url = request.home
               $ share_links = ctx.get('share_links')
               $:macros.ShareModal(share_links, page_url, share_content, "share-modal-wrapper", show_embed=False)

diff --git a/openlibrary/templates/type/edition/modal_links.html b/openlibrary/templates/type/edition/modal_links.html
@@ -9,7 +9,7 @@
 
   $ ga_attr = 'data-ol-link-track=%s' % ga_data if ga_data else ''
   <a href="$href" class="$link_class icon-link" $ga_attr>
-    <img class="icon-link__image" src="$img_src">
+    <img class="icon-link__image" src="$img_src" alt="">
     <div class="icon-link__text">$link_text</div>
   </a>
 

diff --git a/openlibrary/templates/type/edition/title_and_author.html b/openlibrary/templates/type/edition/title_and_author.html
@@ -5,7 +5,7 @@
 
   $ ga_attr = 'data-ol-link-track=%s' % ga_data if ga_data else ''
   <a href="$href" class="$link_class icon-link" $ga_attr>
-    <img class="icon-link__image" src="$img_src">
+    <img class="icon-link__image" src="$img_src" alt="">
     <div class="icon-link__text">$link_text</div>
   </a>
 

diff --git a/static/css/components/nav-bar.less b/static/css/components/nav-bar.less
@@ -58,6 +58,8 @@
 
   .nav-arrow {
     padding-left: 20px;
+    background: none;
+    border: none;
 
     img {
       max-width: unset !important;