Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird white gap at bottom of preview dialog #10095

Closed
cdrini opened this issue Nov 27, 2024 · 8 comments · Fixed by #10142
Closed

Weird white gap at bottom of preview dialog #10095

cdrini opened this issue Nov 27, 2024 · 8 comments · Fixed by #10142
Assignees
@DachiCharkviani
Labels
Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Type: Bug Something isn't working. [managed]

Comments

@cdrini
Copy link
Collaborator

cdrini commented Nov 27, 2024

Problem

image

Reproducing the bug

  1. Go to https://openlibrary.org/books/OL4667107M/Die_Angestellten_vor_dem_Nationalsozialismus
  2. Click "Preview"
  • Expected behavior: The modal should not have a white
  • Actual behavior: It has a white gap

Context

  • Browser (Chrome, Safari, Firefox, etc): FF
  • OS (Windows, Mac, etc): Win
  • Logged in (Y/N): Y
  • Environment (prod, dev, local): prod

Breakdown

Requirements Checklist

  • [ ]

Related files

Stakeholders

Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@cdrini cdrini added Type: Bug Something isn't working. [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Nov 27, 2024
@DachiCharkviani
Copy link
Contributor

DachiCharkviani commented Nov 27, 2024 •
edited
Loading

Hello @cdrini , can I please work on this issue? I am tasked from college course to successfully contribute to an open source code. I already have the development mode of open library built locally, and have replicated the bug. Will start on solving the issue the second I receive green light from you.

@DachiCharkviani DachiCharkviani mentioned this issue Nov 28, 2024
Open
@cdrini cdrini added Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] and removed Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Nov 28, 2024
@cdrini
Copy link
Collaborator Author

cdrini commented Nov 28, 2024

Thank you @DachiCharkviani ! Assigned.

@RayBB
Copy link
Collaborator

RayBB commented Dec 10, 2024

@DachiCharkviani are you still working on this? If so let me know otherwise we'll unassign so someone else can pick it up.

@Craig-Rosario
Copy link
Contributor

If no one is working on this issue, I'd like to work on this.

@RayBB
Copy link
Collaborator

RayBB commented Dec 10, 2024

@Craig-Rosario as you can see there is someone assigned to the issue.
However, if we don't hear from the assignee this week I will look at your PR.

@Craig-Rosario
Copy link
Contributor

@RayBB Sure, no problem

@DachiCharkviani
Copy link
Contributor

@RayBB , I am going to raise PR today or tomorrow.

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Dec 10, 2024
This was referenced Dec 11, 2024
Merged
Merged
@DachiCharkviani
Copy link
Contributor

Hello, I opened a PR for this main branch to merge with the main branch of my forked repo. I believe everything should be working without any issues.

@DachiCharkviani DachiCharkviani mentioned this issue Dec 14, 2024
Merged
@RayBB RayBB added Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. and removed Needs: Response Issues which require feedback from lead labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DachiCharkviani DachiCharkviani

Labels
Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed extra white space issue on book preview modals DachiCharkviani/openlibrary
4 participants
@RayBB @cdrini @DachiCharkviani @Craig-Rosario