-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed extra white space issue on book preview modals #10142
base: master
Are you sure you want to change the base?
Conversation
Fixed extra white space issue on book preview modals
@DachiCharkviani my local environment to test changes is broken and I'm working on fixing it. |
Hello, @RayBB Thank you for your answer. No rush, but if it is processed as soon as possible that will greatly benefit me since I have to show in my college class that I have successful merge in open source code on git for extra credit. Once, again thanks. @cdrini Waiting for your approval then! All the best. |
implemented the Richer UI access when downloading the app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove all changes not related to the modal.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10142 +/- ##
==========================================
+ Coverage 17.12% 17.44% +0.31%
==========================================
Files 89 89
Lines 4752 4792 +40
Branches 831 848 +17
==========================================
+ Hits 814 836 +22
- Misses 3428 3436 +8
- Partials 510 520 +10 ☔ View full report in Codecov by Sentry. |
Revert "implemented the Richer UI access when downloading the app"
@RayBB done! |
@RayBB Could you please respond for the merge? If everything is on point and satisfies the requirements I would like to proceed as soon as possible because deadline for the credit is today night. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DachiCharkviani great work!
I tested this on desktop and on mobile and it works great.
One small change I pushed up is to remove some unused css after you removed the class.
Removing the floater and the iframe-container class were both needed.
Now we just need one of the staff to review/merge it.
Probably @cdrini but I think he might be on vacation now.
Closes #10095
Worked with @Graissov and @khiyami on this issue.
Fix/Refactor excess whitespace on book review pop-ups.
Technical
Testing
Go to this page and click preview(or any other book with preview): http://localhost:8080/works/OL16086453W/Pioneers
Screenshot
Before:
After:
Stakeholders
@RayBB