Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide rest of registration form if third-party login used #9540

Closed
Tracked by #9315
rebecca-shoptaw opened this issue Jul 9, 2024 · 1 comment
Closed
Tracked by #9315

Hide rest of registration form if third-party login used #9540

rebecca-shoptaw opened this issue Jul 9, 2024 · 1 comment
Assignees
Labels
Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] registration Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed]

Comments

@rebecca-shoptaw
Copy link
Collaborator

rebecca-shoptaw commented Jul 9, 2024

Dependency to epic #7694. Subtask of #9315.

Problem

As part of an ongoing effort to clarify the registration flow, we want to hide the rest of the OL registration form if the user selects "Sign in with Google" and the third party login form grows.

This way, users will know which form to submit, but will still be able to return to the regular form by selecting "Cancel"

Expected behaviour / screenshots

IA login screen

Like the above, but the "OR" and everything below it would no longer appear.

Proposal & Constraints

Should hopefully be very simple, just intercepting the resize handler in ia_thirdparty_logins.js to add a quick display: none to the relevant divs. Similar to the approach in covers.js in #9418.

Related files

create.html
ia_thirdparty_logins.js

Stakeholders

@CDRI


Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@rebecca-shoptaw rebecca-shoptaw added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] registration Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Jul 9, 2024
@rebecca-shoptaw rebecca-shoptaw self-assigned this Jul 9, 2024
@cdrini
Copy link
Collaborator

cdrini commented Jul 10, 2024

We chatted and since this will only affect the case where a user already has an IA account, but no OL account, which is preeeetty niche, and there are a number of edge cases related to how to detect the IA iframe has expanded, and if the user has already entered information into the registration form; it seems like it's not worth the code.

@cdrini cdrini closed this as not planned Won't fix, can't repro, duplicate, stale Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] registration Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants