Disable /authors shuffle sort for now #10023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 11, 2024 20:14
scottbarnes
force-pushed
the
help-manage-bots-hitting-authors
branch
from
4bd54d8
to
7cdf833
Compare
cdrini
reviewed
Nov 12, 2024
|
|
||
| # randomly sorting will be removed. For now just return 200 | ||
| if ($is_random_sort = 1) { | ||
| return 200 ""; |
There was a problem hiding this comment.
Note this is effectively indiscriminately returning 200 for all /authors requests with url param sort=random_.* . It would be nice if we could achieve this goal with a little less nginx config, but merging this as is for now because it's blocking deploys. (Took a look and was once again reminded the nginx configs are rather unpleasant to write :P )
Oh this is blocking the deploy due to too much traffic to this endpoint.
cdrini
changed the title
cdrini
changed the title
cdrini
added
the
Temporary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10022
Adds some rules that were uncommitted and probably useful. Also reorders some rules on the theory that matters.
Technical
Testing
Ensure the website still loads.
Screenshot
With these rules in place
Stakeholders
@cdrini