10046/fix/question char not searchable fixed

[ronibhakta1]

Closes #10046
Ok as you told me to do some tests on solr, i have taken some references from previous issue fix and made some changes as required in codebase and i have done the tests.
@cdrini just try to run it on your end once

Support for "?" search as a string

Technical

Fix in the solr check and all other constrains to get overcome though all other previous done by other contributor in 2023, there are were some issues with the "?" search which has a different behavior which helps to search

Screenshot

Testing

"hello?" as a string

"? hello? world" as a string

"hello? world" as a string

"?" as a string

Stakeholders

[ronibhakta1]

@cdrini have you checked the updates?

[cdrini]

Awesome, thanks for revising @ronibhakta1 ! Hmm, the results there don't quite look correct; in your screenshot, it seems like the WDGF is converting "?" to nothing! So the search will still not work. This one might be a bit more hairy ; also are you sure you reset your environment after making the changes to the manage-schema ? I.e.

docker compose down
docker volume rm openlibrary_solr-data_1 openlibrary_solr-updater-data_1  # I think these are the right volumes; double check by running `docker volume ls`
docker compose up -d

Another way to test is to create a book on your local open library to e.g. set the title as ? , and then you can check if it shows up in search.

Let me know if you have any other questions 👍

[ronibhakta1]

Awesome, thanks for revising @ronibhakta1 ! Hmm, the results there don't quite look correct; in your screenshot, it seems like the WDGF is converting "?" to nothing! So the search will still not work. This one might be a bit more hairy ; also are you sure you reset your environment after making the changes to the manage-schema ? I.e.

docker compose down
docker volume rm openlibrary_solr-data_1 openlibrary_solr-updater-data_1  # I think these are the right volumes; double check by running `docker volume ls`
docker compose up -d

Another way to test is to create a book on your local open library to e.g. set the title as ? , and then you can check if it shows up in search.

Let

I will check with those and connect with you after running some tests