Implemented Richer UI on App Download from Chrome #10143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please be sure to read the full discussion on the original issue. Particularly the comment to update the mockups. #8929 (comment) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10143 +/- ##
==========================================
+ Coverage 17.12% 17.44% +0.31%
==========================================
Files 89 89
Lines 4752 4792 +40
Branches 831 848 +17
==========================================
+ Hits 814 836 +22
- Misses 3428 3436 +8
- Partials 510 520 +10 ☔ View full report in Codecov by Sentry. |
@RayBB Will modify the standards. No problem. Will commit changes tomorrow and update you. |
|
@DachiCharkviani any update on this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Template
What issue does this PR close?
Closes #8929
Worked with @Seckhen and @NickDevi on this issue.
What does this PR achieve?
Feature: Adds richer install UI for Progressive Web App (PWA) by incorporating screenshots for both desktop and mobile, along with a description.
Technical
This PR updates the manifest file to include screenshots for different devices (desktop and mobile). It utilizes the form_factor property to differentiate between wide (desktop) and narrow (mobile) screens, ensuring compatibility with Chrome's richer install UI.
Screenshots were added for the following contexts:
Desktop views of key pages like Main Page, Search Books, and Student Library.
Mobile views of the same pages optimized for narrow displays.
The manifest.json file was updated, and screenshots were uploaded to static folder.
Testing
To verify:
Clone the repository and switch to this branch.
Link the updated manifest.json to your development build.
Use Chrome to inspect the richer install UI for PWAs:
Open chrome://inspect/#apps.
Check that all screenshots are visible for both desktop and mobile contexts.
Test the UI responsiveness by viewing the install banner on different screen sizes.
Screenshot
Evidence of functionality:
Before:
After Desktop screenshots:
After Mobile screenshots:
Stakeholders
@RayBB (Lead)