Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Read More Button Display Logic to Avoid Unnecessary Display #9627

Closed
wants to merge 6 commits into from
Closed

Fixed Read More Button Display Logic to Avoid Unnecessary Display #9627

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
46cef8f
Fixed Read More Button Display Logic to Avoid Unnecessary Display
CodeMaverick2 Jul 25, 2024
8f51454
Fixed Read More Button Display Logic to Avoid Unnecessary Display
CodeMaverick2 Jul 25, 2024
1d505f8
Fixed Read More Button Display Logic to Avoid Unnecessary Display fix…
CodeMaverick2 Jul 25, 2024
6e3dc85
Fixed Read More Button Display Logic to Avoid Unnecessary Display and…
CodeMaverick2 Jul 31, 2024
17ea8cf
Merge branch 'internetarchive:master' into issue1
CodeMaverick2 Sep 11, 2024
411fb1a
Fixed Read More Button Display Logic to Avoid Unnecessary Display
CodeMaverick2 Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions openlibrary/plugins/openlibrary/js/readmore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,12 @@ export class ReadMoreComponent {
this.$readMoreButton = container.querySelector('.read-more__toggle--more');
this.$readLessButton = container.querySelector('.read-more__toggle--less');

this.collapsedHeight = parseFloat(this.$content.style.maxHeight);
if (!this.$content || !this.$readMoreButton || !this.$readLessButton) {
return;
}
this.collapsedHeight = parseFloat(getComputedStyle(this.$content).maxHeight);
this.fullHeight = this.$content.scrollHeight;
this.manuallyExpanded = false;
}

attach() {
Expand Down Expand Up @@ -44,18 +48,23 @@ export class ReadMoreComponent {
expand() {
this.$container.classList.add('read-more--expanded');
this.$content.style.maxHeight = `${this.fullHeight}px`;
this.$readMoreButton.style.display = 'none';
this.$readLessButton.style.display = 'block';
}

collapse() {
this.$container.classList.remove('read-more--expanded');
this.$content.style.maxHeight = `${this.collapsedHeight}px`;
this.$readMoreButton.style.display = 'block';
this.$readLessButton.style.display = 'none';
}

reset() {
if (!this.$content || !this.$readMoreButton) return;
this.fullHeight = this.$content.scrollHeight;
// Fudge factor to account for non-significant read/more
// (e.g missing a bit of padding)
if (this.$content.scrollHeight <= (this.collapsedHeight + 1)) {
if (this.$content.scrollHeight <= (this.collapsedHeight + this.$readMoreButton.offsetHeight + 1)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the only change that is necessary here. Please revert the other changes since they are unnecessary.

this.expand();
this.$container.classList.add('read-more--unnecessary');
} else {
Expand Down
Loading