Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment with TOC in solr #9898

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented Sep 20, 2024

Closes #

Technical

  • Add a new chapter field to solr and populate it on the edition level with the toc data in markdown format
  • On the work level, set it to the unsorted set of all its editions chapters.
  • RISK: This is a lot of new data in solr, and duplicated! Could cause bloat/perf issues
  • RISK: We use the work-level highlighting to display the toc in the search view, but we don't know which book the toc entry came from... Might need to include some edition data in there.
  • Add ability to see matching subjects to search page
  • Add ability to see matching chapters to search page
  • Special deploy: Need to add the new chapters field to solr. This can be done via the solr UI. Note this of course won't backfill the data, a full reindex is needed for that, but that will make it possible to merge/deploy this without needing the solr_next flag.

Testing

Screenshot

Stakeholders

@cdrini cdrini added Needs: Special Deploy This PR will need a non-standard deploy to production On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing labels Sep 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.05%. Comparing base (ce16a79) to head (3229519).
Report is 444 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9898      +/-   ##
==========================================
+ Coverage   16.06%   17.05%   +0.99%     
==========================================
  Files          90       89       -1     
  Lines        4769     4725      -44     
  Branches      832      829       -3     
==========================================
+ Hits          766      806      +40     
+ Misses       3480     3409      -71     
+ Partials      523      510      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cdrini cdrini force-pushed the feature/toc-solr2 branch 5 times, most recently from 43aa92b to 3229519 Compare September 24, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Special Deploy This PR will need a non-standard deploy to production On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants