reject Amazon dvd imports #9905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottbarnes
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Great work, @DebbieSan. Thanks for this! These tests especially will be really helpful in making further improvements to this import pipeline.
DanielleInkster
pushed a commit
to DanielleInkster/openlibrary
that referenced
this pull request
Oct 1, 2024
* reject Amazon DVD imports * Handle `None` cases as the API can in theory return `None`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9879
Prevents dvds from being imported from the Amazon API. They were previously being imported as books.
Technical
If Product_group OR Physical_format match 'dvd' it will not be imported.
Testing
unit tests included in tests_vendors.py
Stakeholders
@scottbarnes