Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bulk tagger for collections #9907

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jimchamp
Copy link
Collaborator

@jimchamp jimchamp commented Sep 24, 2024

Adds new collection type to the bulk tagger.

Screenshot 2024-09-24 144859
After adding new collection tag named some-collection-identifier.

When changes are submitted, the collection tags are added to the form, with the collectionID: prefix, in the subjects array. For example, if the changes in the above image were submitted, there would be a collectionID:some-collection-identifier label in the affected works' subjects field.

underlined_subject
New label with prefix is appended to the work's subjects list (underlined in red, above).

Technical

Testing

  1. Create a new collection tag with the bulk tagger.
  2. Add the tag to a work by pressing the "Submit" button.
  3. View the updated work's subjects field, and verify that the new collection is present.
  4. Verify that the new label has the collectionID: prefix.
  5. Remove the new label via the bulk tagger.
  6. Ensure that the work record has been updated, and that the collection subject has been removed from subjects.

Screenshot

Stakeholders

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 17.02%. Comparing base (ce16a79) to head (ddc5e18).
Report is 446 commits behind head on master.

Files with missing lines Patch % Lines
...y/plugins/openlibrary/js/bulk-tagger/BulkTagger.js 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9907      +/-   ##
==========================================
+ Coverage   16.06%   17.02%   +0.96%     
==========================================
  Files          90       89       -1     
  Lines        4769     4734      -35     
  Branches      832      829       -3     
==========================================
+ Hits          766      806      +40     
+ Misses       3480     3418      -62     
+ Partials      523      510      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants