Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unreferenced BulkTagger code #9909

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove unreferenced BulkTagger code #9909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eeb062f
Remove unreferenced style rules
jimchamp Sep 25, 2024
b8d0bae
Remove unused `BulkTagger` property
jimchamp Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions openlibrary/plugins/openlibrary/js/bulk-tagger/BulkTagger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,17 +102,6 @@ export class BulkTagger {
*/
this.existingSubjects = new Map()

/**
* Stores arrays of selected menu options.
*
* Tag names are the keys to this map. Corresponding arrays
* will contain menu options having the same name, but different
* types.
*
* @member {Map<String, Array<MenuOption>}
*/
this.menuOptions = new Map()

/**
* Array containing OLIDs of each selected work.
*
Expand Down
55 changes: 0 additions & 55 deletions static/css/components/tagging-menu.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,22 +72,6 @@
}
}

.search-subject-row {
display: flex;
align-items: center;
font-size: 16px;
border-bottom: 1px solid @light-grey;
border-top: 1px solid @light-grey;
padding: 7px;
width: 100%;
min-height: 38px;
cursor: pointer;
}

.search-subject-row:hover {
background-color: @button-hover-blue;
}

// Holds the button
.submit-tags-section {
padding: 5px;
Expand Down Expand Up @@ -148,45 +132,6 @@
}
}

.search-subject-row-subject-info {
display: flex;
flex-direction: column;
justify-content: center;
align-items: flex-end;
gap: 2px;
margin-left: auto;
}

.search-subject-work-count {
color: @grey;
font-size: 8px;
margin-right: 2px;
}

.search-subject-type {
font-size: 11px;
font-weight: 700;
border-radius: 8px;
padding: 2px 6px;
}

.new-selected-subject-tag {
border: 1px solid @lighter-grey;
padding: 2px 6px;
font-size: 13px;
height: 20px;
width: fit-content;
text-align: center;
}

.remove-selected-subject {
font-size: 11px;
color: @black;
font-weight: bold;
cursor: pointer;
margin-left: 7px;
}

.selected-tag {
color: @black;
cursor: pointer;
Expand Down