Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to sort of edit TOCs with authors/etc #9915

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented Sep 27, 2024

Part of #8756

Adds the new fields to a new column in the markdown as JSON. This isn't a great UI, but, more importantly, it makes it so that the extra fields aren't erased when someone edits an openlibrary record with authors/etc already in the TOC field.

Depends on #9910 .

Technical

  • Add an ol-message CSS component for small messages; inspired by https://primevue.org/message/
  • Add space indenting to table of contents editor for easier legilibity

Testing

Screenshot

image

Stakeholders

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.05%. Comparing base (ce16a79) to head (e1e5029).
Report is 453 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9915      +/-   ##
==========================================
+ Coverage   16.06%   17.05%   +0.99%     
==========================================
  Files          90       89       -1     
  Lines        4769     4725      -44     
  Branches      832      829       -3     
==========================================
+ Hits          766      806      +40     
+ Misses       3480     3409      -71     
+ Partials      523      510      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

At least fix editing book with complex TOCs removing extra fields!
@cdrini cdrini changed the title Add ability (sort of) to edit TOCs with authors/etc Add ability to sort of edit TOCs with authors/etc Sep 27, 2024
@cdrini cdrini added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Sep 27, 2024
@cdrini cdrini added the Priority: 1 Do this week, receiving emails, time sensitive, . [managed] label Sep 27, 2024
@cdrini cdrini marked this pull request as ready for review September 27, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing Priority: 1 Do this week, receiving emails, time sensitive, . [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants