-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Project Runeberg as a trusted book provider #9984
base: master
Are you sure you want to change the base?
Conversation
Project Runeberg is similar to Project Gutenberg, but focuses on Nordic and Scandinavian authors and literature. These identifiers basically correspond to https://www.wikidata.org/wiki/Property:P3154 and https://www.wikidata.org/wiki/Property:P3155 in Wikidata. Closes internetarchive#9981
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things I need to fix later or that I need to ask about. 📝
openlibrary/templates/book_providers/runeberg_download_options.html
Outdated
Show resolved
Hide resolved
$if render_once('runeberg-toast'): | ||
<div class="toast toast--book-provider" data-toast-trigger=".cta-btn--runeberg" id="runeberg-toast" style="display:none"> | ||
<div class="toast__body"> | ||
$:_('This book is available from <a href="https://runeberg.org/">Project Runeberg</a>. Project Runeberg is a trusted book provider of classic Nordic (Scandinavian) literature in electronic form.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the link/href
attribute be dealt with differently than having it raw in the translatable string?
This is mostly copy/pasting of existing support for Project Gutenberg, with a `s/[gG]utenberg/[rR]uneberg/` replacement, but some things have had additional adjustment (like the `download_options` HTML page). Fixes internetarchive#9983
ed44791
to
4fd2371
Compare
Running this in a GitPod instance and trying to add the identifier
|
Edit: I now see you were having the issue with books not authors. Let me take a look. Perhaps try stopping and starting the docker compose again? |
Adding runeburg IDs to a book worked (showing on the book page) Which seems to be related to
However, I don't know enough about your templating engine to fix it. Maybe @cdrini can chime in |
Closes #9983
feature
Technical
NOTE: This depends on #9981 and as such builds on top of #9982 – hence the commit from there is in included in this PR currently. #9982 is a lot simpler than this PR though, so hopefully that will get merged before this one and this can be rebased on top of the main branch before getting undrafted.
This is mostly copy/pasting of existing support for Project Gutenberg, with a
s/[gG]utenberg/[rR]uneberg/
replacement, but some things have had additional adjustment (like thedownload_options
HTML page).Testing
Screenshot
Stakeholders