Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap order of isActive and coverUrl in updateDroppersOnListCreation. #9999

Conversation

EmilyIsCoding
Copy link
Contributor

@EmilyIsCoding EmilyIsCoding commented Nov 6, 2024

Closes #9701

Fixes the issue where lists created on search page initially appear checked in every dropper

Technical

  • Minor changes made where isActive and coverUrl's order are swapped in updateDroppersOnListCreation to match onListCreationSuccess(listKey, listTitle, isActive, coverUrl)

Testing

  • Go to the /search page, and ensure that there are multiple search results.
  • Using the "My Books" dropper found in the first search result, create a new list.
  • Expected behavior: The new list appears in each dropper, but is only checked in the first dropper.

Screenshot

Stakeholders

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 17.12%. Comparing base (ce16a79) to head (347bff9).
Report is 564 commits behind head on master.

Files with missing lines Patch % Lines
.../plugins/openlibrary/js/my-books/CreateListForm.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9999      +/-   ##
==========================================
+ Coverage   16.06%   17.12%   +1.06%     
==========================================
  Files          90       89       -1     
  Lines        4769     4752      -17     
  Branches      832      831       -1     
==========================================
+ Hits          766      814      +48     
+ Misses       3480     3428      -52     
+ Partials      523      510      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @EmilyIsCoding! This seems to be working as expected.

@jimchamp jimchamp merged commit 425184f into internetarchive:master Nov 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lists created on search page initially appear checked in every dropper
3 participants