Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added github actions flow #4

Merged
merged 7 commits into from
Jul 26, 2023
Merged

added github actions flow #4

merged 7 commits into from
Jul 26, 2023

Conversation

OlegPhenomenon
Copy link
Contributor

@OlegPhenomenon OlegPhenomenon commented Jul 25, 2023

You did what?

  • I added to Github Action the bundle-audit security check for gem vulnerabilities
  • I added to Github Action a code security check with the brakeman static analyzer.
  • I've added a test pass checker to Github Action

What did you do that for?

  • To be aware of different vulnerabilities, dangerous code that might be vulnerable to attacks, and also to be sure that nothing is broken, because there are situations when you forget to run tests in your working environment.

Did you change anything else?

  • Yes, I firstly updated the gems that bundle-audit pointed to
  • I also added a check to the code where I use metaprogramming and the brakeman gem pointed out that this is unsafe
  • I fixed some tests that were not working correctly
  • I fixed some of the code where the tests were crashing
  • I commented out a number of tests to check jobs queues, as there are issues with redis on staging and while everyone is on holiday, I decided to run jobs immediately rather than asynchronously.
  • Added brakeman.ignore one warning which I think is safe. The thing is that he doesn't like that I use the :role attribute in the parameters and he thinks that because of that users can manipulate the access level, but :role in the context of my business logic applies to a normal contact, a typical entity that doesn't have the ability to influence the system in any way.

How to test?

  • Overall, the system should work as far as tests go.
  • However, I have made a number of changes to the code:
    • Check authorisation and access levels
    • Check how synchronisation of adding data from the registry to eedirekt works

@OlegPhenomenon OlegPhenomenon force-pushed the ruby-github-actions branch 3 times, most recently from ee015a4 to 221e5d9 Compare July 26, 2023 10:31
@OlegPhenomenon OlegPhenomenon merged commit 1193226 into main Jul 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant