Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client certificates can be optional #59

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

client certificates can be optional #59

wants to merge 4 commits into from

Conversation

lidakaml
Copy link

@lidakaml lidakaml commented Jun 7, 2022

  • If require_client_certs is set to true or is missing, everything works as before and client certs are required.
  • If require_client_certs is set to false epp_tls_worker will not expect a client certificate, but if provided will verify it.

@vohmar
Copy link
Contributor

vohmar commented Jun 8, 2022

Thank you @lidakaml! Code is reviewed and approved. We need to add tests to this though before it's ready to merge.

@lidakaml
Copy link
Author

lidakaml commented Jun 8, 2022

Thank you for your quick response!
Greetings from nic.lv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maricavor maricavor maricavor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lidakaml @vohmar @maricavor