Merge pull request #702 from internetee/registry-701

Bypass validation on contact transfers

app/models/concerns/contact/transferable.rb

@@ -14,7 +14,7 @@ def transfer(new_registrar)
     new_contact.regenerate_code
     new_contact.regenerate_auth_info
     new_contact.remove_address unless self.class.address_processing?
-    new_contact.save!
+    new_contact.save(validate: false)
     new_contact
   end
 

test/fixtures/contacts.yml

@@ -30,3 +30,9 @@ acme_ltd:
   ident_country_code: US
   code: acme-ltd-001
   auth_info: 720b3c
+
+invalid:
+  name: any
+  code: any
+  auth_info: any
+  registrar: bestnames

test/models/contact/contact_test.rb

@@ -8,4 +8,8 @@ def setup
   def test_validates
     assert @contact.valid?
   end
+
+  def test_invalid_fixture_is_invalid
+    assert contacts(:invalid).invalid?
+  end
 end

test/models/contact/contact_transfer_test.rb

@@ -48,6 +48,14 @@ def test_creates_new_contact
     end
   end
 
+  def test_bypasses_validation
+    @contact = contacts(:invalid)
+
+    assert_difference 'Contact.count' do
+      @contact.transfer(@new_registrar)
+    end
+  end
+
   def test_changes_registrar
     new_contact = @contact.transfer(@new_registrar)
     assert_equal @new_registrar, new_contact.registrar