Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle company register API data type errors #2731

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: handle company register API data type errors #2731

wants to merge 3 commits into from

Conversation

OlegPhenomenon
Copy link
Contributor

  • Add type checking for contact ident before calling company register API
  • Add logging for debugging company details processing
  • Prevent TypeError when converting Symbol to Integer in company_register gem

The changes help to:

  1. Prevent errors when contact ident is not a string
  2. Improve debugging capabilities by logging API responses
  3. Better handle edge cases in company register status checks

@OlegPhenomenon
fix: handle company register API data type errors
3512537 
- Add type checking for contact ident before calling company register API
- Add logging for debugging company details processing
- Prevent TypeError when converting Symbol to Integer in company_register gem

The changes help to:
1. Prevent errors when contact ident is not a string
2. Improve debugging capabilities by logging API responses
3. Better handle edge cases in company register status checks
@OlegPhenomenon
transform ident to the string
5f7c029
@OlegPhenomenon
downgrade ruby version
9cdd349
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@OlegPhenomenon