[WIP] Fix #1314 - security.txt full url in finding #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwbroersma
force-pushed
the
gh1314-sectxt-full-url-finding
branch
3 times, most recently
from
f1901cc
to
af11a77
Compare
|
The translation files are exclusively managed through the content repo. Updates directly to the translation files will be overwritten when we do a content update. I don't think you need to update django.po yourself, it's not in the repo, I am pretty sure it's generated in the Dockerfile. For the API, we also need to update openapi.yaml and bump the API version. |
mxsasha
force-pushed
the
gh1314-sectxt-full-url-finding
branch
from
1c08584
to
40bc16c
Compare
mxsasha
force-pushed
the
gh1314-sectxt-full-url-finding
branch
from
40bc16c
to
67179de
Compare
Signed-off-by: Sasha Romijn <[email protected]>
mxsasha
force-pushed
the
gh1314-sectxt-full-url-finding
branch
from
67179de
to
bc0c08f
Compare
mxsasha
reviewed
Oct 17, 2024
| # ), | ||
| migrations.RunSQL( | ||
| sql=[ | ||
| "ALTER TABLE checks_domaintestappsecpriv ADD COLUMN securitytxt_found_url VARCHAR(8000);", |
There was a problem hiding this comment.
Maybe we can keep AddField and only use custom artisanal SQL for the UPDATE?
There was a problem hiding this comment.
It would probably also fix the build failure, as the migrations framework now does not know this SQL adds that field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1314.
In develop I have to run
python3 manage.py migrate, I thought db-migrate should do this automatically?I'm having some trouble with the translation files and how to update the django.po from the main.po (I know there is the content repo) by running
python3 bin/pofiles.py to_django/python3 manage.py compilemessages.The current content change is:
$ sed -r -i 's/(security.txt )(retrieved from|opgehaald van)( \{hostname)/\1\2 {url/'