Stipped leading whitespace characters in lexer() #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stripped any and all whitespace characters from the line in lexer(line) before we try to find preprocessor directives.
Moved the lstrip() call to the start of lexer() to improve reliability.
cxw42
reviewed
Mar 20, 2018
| # return values are (squelch, metadata) | ||
| # strip any and all leading whitespace characters | ||
| line = line.lstrip() | ||
| # return values are (squelch, metadata) |
There was a problem hiding this comment.
For the sake of docstrings, I would suggest the other way around:
"""Returns (squelch, metadata)."""
# strip leading whitespace characters for compatibility with the C preprocessor.
line = line.lstrip()
|
This allow indented (by whitespace) directives in python? That would be great I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stripped any and all whitespace characters from the line in lexer(line) before we try to find preprocessor directives. I believe insensitivity to leading whitespace is standard for modern C preprocessors.